copy of Tour Mode Clean Develop 202403 #3904
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # production/austin # production/sfbay # src/main/scala/beam/agentsim/agents/PersonAgent.scala # src/main/scala/beam/agentsim/agents/household/HouseholdFleetManager.scala # src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala # src/main/scala/beam/agentsim/infrastructure/taz/TAZTreeMap.scala # src/main/scala/beam/router/skim/core/RideHailSkimmer.scala
…mode-clean-develop202403 # Conflicts: # production/seattle # production/sfbay # src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala # src/main/scala/beam/router/skim/readonly/ODSkims.scala
…mode-clean-develop202403
…velop202403 # Conflicts: # src/main/scala/beam/agentsim/agents/PersonAgent.scala # src/main/scala/beam/agentsim/agents/modalbehaviors/DrivesVehicle.scala # src/main/scala/beam/agentsim/events/PathTraversalEvent.scala
…velop202403 # Conflicts: # src/main/scala/beam/agentsim/agents/parking/ChoosesParking.scala # src/test/scala/beam/agentsim/infrastructure/ZonalParkingManagerSpec.scala
…mode-clean-develop202403 # Conflicts: # build.gradle
|
test! |
wrashid
reviewed
Oct 31, 2024
| availableVehicles, | ||
| choosesModeData.personData.currentTourPersonalVehicle | ||
| ) | ||
| val (chosenTourMode, chosenTourVehicleMap) = chosenTourModeAndVehicle.headOption match { |
There was a problem hiding this comment.
We are using headOption on a map here. Maps usually have random order. This means, we are returning a random value. If different behaviour is needed, some sorting might be needed.
wrashid
reviewed
Oct 31, 2024
| trips: Vector[EmbodiedBeamTrip], | ||
| availableVehicles: Vector[VehicleOrToken] = Vector.empty[VehicleOrToken], | ||
| currentTourPersonalVehicle: Option[Id[BeamVehicle]] = None | ||
| ): mutable.Map[Option[BeamTourMode], mutable.Map[EmbodiedBeamTrip, Option[BeamVehicle]]] = { |
There was a problem hiding this comment.
We are returning a map here. The keys of this Map is Option[BeamTourMode]. But we are only putting Some objects there. So Option is not really needed here.
|
test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy created in an attempt to fix strange CI behavior
This change is